-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
synchronize Course/Session objective description/parentObjectives FadeText status #8215
base: master
Are you sure you want to change the base?
synchronize Course/Session objective description/parentObjectives FadeText status #8215
Conversation
packages/ilios-common/addon/components/course/objective-list-item.js
Outdated
Show resolved
Hide resolved
Behavior looks great to me! There are some possibly artistic choices in what expands all. Clicking the expander catches everything, but clicking to edit a title or parents doesn't. I played with it for a while and I think I like this, but wanted to call it out for further testing by @dartajax. |
d425132
to
f713d10
Compare
@dartajax @jrjohnson I fixed the buggy icon we saw in the standup. I also fixed some icon inconsistencies I saw (per the light on dark vs dark on light styling). I also also fixed how the ObjectiveSortManager displayed so the draggable icon now sits in the center like before. I know that was for a future PR but I figured it out, so :D |
Still gotta fix the Session version of these things, tho... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed and click-tested. LGTM.
i spoke too soon. the course objectives version of this works as intended, but session objectives is bugged.
96b7d70
to
3765dca
Compare
Got all the syncing stuff working, and fixed existing tests. Even without Code Climate warning me, I know new tests need to be written to account for the changes, but just want to make sure this is cool so far. |
…ow's faded FadeText item is expanded
… markup with less egregious spacing
3765dca
to
74060e4
Compare
@dartajax that's a valid visual point. I'm not sure yet how to improve the whitespace, but I will look into it. |
Fixes ilios/ilios#5645
Whew, this was a long time coming for me. Basically, be it Courses or Sessions, their objectives (and their Description and Parent Objective columns) now synchronize in individual rows, so that if you expand one column, the other column expands, as well (and in the opposite direction, too). Had to learn how to send functions from parent objectives down to child objectives and all that, so fun!
ObjectiveSortManager
has to short-circuit this by having its own function that overrides the one sent byObjectiveListItem
.