fixed tests

ilios · Nov 26, 2024 · 3765dca · 3765dca
1 parent b666adc
commit 3765dca
Show file tree

Hide file tree

Showing 15 changed files with 29 additions and 31 deletions.
diff --git a/packages/frontend/tests/acceptance/course/competencies-test.js b/packages/frontend/tests/acceptance/course/competencies-test.js
@@ -69,7 +69,7 @@ module('Acceptance | Course - Competencies', function (hooks) {
       details: true,
       courseObjectiveDetails: true,
     });
-    await page.details.objectives.objectiveList.objectives[1].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[1].parents.manage();
     const m = page.details.objectives.objectiveList.objectives[1].parentManager;
     await m.competencies[1].objectives[0].add();
     assert.ok(m.competencies[0].objectives[0].notSelected);

diff --git a/packages/frontend/tests/acceptance/course/objectiveparents-allow-multiple-test.js b/packages/frontend/tests/acceptance/course/objectiveparents-allow-multiple-test.js
@@ -5,7 +5,7 @@ import { setupApplicationTest } from 'frontend/tests/helpers';
 import page from 'ilios-common/page-objects/course';
 import percySnapshot from '@percy/ember';
 
-module('Acceptance | Course - Multiple Objective  Parents', function (hooks) {
+module('Acceptance | Course - Multiple Objective Parents', function (hooks) {
   setupApplicationTest(hooks);
   hooks.beforeEach(async function () {
     this.user = await setupAuthentication();
@@ -65,7 +65,7 @@ module('Acceptance | Course - Multiple Objective  Parents', function (hooks) {
       'program-year objective 1',
     );
 
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
 
     assert.strictEqual(m.selectedCohortTitle, 'program 0 cohort 0');
@@ -92,7 +92,7 @@ module('Acceptance | Course - Multiple Objective  Parents', function (hooks) {
       page.details.objectives.objectiveList.objectives[0].description.text,
       'course objective 0',
     );
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
 
     await m.competencies[0].objectives[2].add();

diff --git a/packages/frontend/tests/acceptance/course/objectiveparents-inactive-test.js b/packages/frontend/tests/acceptance/course/objectiveparents-inactive-test.js
@@ -64,7 +64,7 @@ module('Acceptance | Course - Objective Inactive Parents', function (hooks) {
     assert.strictEqual(objectives[0].parents.list.length, 1);
     assert.strictEqual(objectives[0].parents.list[0].text, 'inactive selected');
 
-    await objectives[0].parents.list[0].manage();
+    await objectives[0].parents.manage();
     const m = objectives[0].parentManager;
 
     assert.strictEqual(m.selectedCohortTitle, 'program 0 cohort 0');

diff --git a/packages/frontend/tests/acceptance/course/objectiveparents-multiplecohorts-test.js b/packages/frontend/tests/acceptance/course/objectiveparents-multiplecohorts-test.js
@@ -75,7 +75,7 @@ module('Acceptance | Course with multiple Cohorts - Objective Parents', function
       page.details.objectives.objectiveList.objectives[0].parents.list[1].text,
       'program-year objective 3',
     );
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
 
     await m.selectCohort(1);
@@ -135,7 +135,7 @@ module('Acceptance | Course with multiple Cohorts - Objective Parents', function
       page.details.objectives.objectiveList.objectives[0].parents.list[1].text,
       'program-year objective 3',
     );
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
 
     await m.selectCohort(1);
@@ -185,7 +185,7 @@ module('Acceptance | Course with multiple Cohorts - Objective Parents', function
       page.details.objectives.objectiveList.objectives[0].parents.list[1].text,
       'program-year objective 3',
     );
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
 
     await m.selectCohort(1);

diff --git a/packages/frontend/tests/acceptance/course/objectiveparents-nocohorts-test.js b/packages/frontend/tests/acceptance/course/objectiveparents-nocohorts-test.js
@@ -41,7 +41,7 @@ module('Acceptance | Course with no cohorts - Objective Parents', function (hook
 
     assert.strictEqual(firstObjective.description.text, 'course objective 0');
     assert.ok(firstObjective.parents.empty);
-    await firstObjective.parents.list[0].manage();
+    await firstObjective.parents.manage();
     const m = firstObjective.parentManager;
 
     assert.ok(m.hasNoCohortWarning);
@@ -50,7 +50,7 @@ module('Acceptance | Course with no cohorts - Objective Parents', function (hook
     await page.details.cohorts.selectable[0].add();
     await page.details.cohorts.save();
     assert.strictEqual(page.details.cohorts.current.length, 1);
-    await firstObjective.parents.list[0].manage();
+    await firstObjective.parents.manage();
 
     assert.strictEqual(m.selectedCohortTitle, 'program 0 cohort 0');
     assert.strictEqual(m.competencies.length, 1);
@@ -64,7 +64,7 @@ module('Acceptance | Course with no cohorts - Objective Parents', function (hook
     await page.details.cohorts.selected[0].remove();
     await page.details.cohorts.save();
     assert.strictEqual(page.details.cohorts.current.length, 0);
-    await firstObjective.parents.list[0].manage();
+    await firstObjective.parents.manage();
     assert.ok(m.hasNoCohortWarning);
   });
 });
diff --git a/packages/frontend/tests/acceptance/course/objectiveparents-test.js b/packages/frontend/tests/acceptance/course/objectiveparents-test.js
@@ -66,7 +66,7 @@ module('Acceptance | Course - Objective Parents', function (hooks) {
       'program-year objective 0',
     );
 
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
 
     assert.strictEqual(m.selectedCohortTitle, 'program 0 cohort 0');
@@ -108,7 +108,7 @@ module('Acceptance | Course - Objective Parents', function (hooks) {
     );
 
     await percySnapshot(getUniqueName(assert, 'default background color'));
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     await percySnapshot(getUniqueName(assert, 'default background color'));
 
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
@@ -152,7 +152,7 @@ module('Acceptance | Course - Objective Parents', function (hooks) {
     );
 
     await percySnapshot(getUniqueName(assert, 'default background color'));
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     await percySnapshot(getUniqueName(assert, 'managed background color'));
 
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;

diff --git a/packages/frontend/tests/acceptance/course/publishall-test.js b/packages/frontend/tests/acceptance/course/publishall-test.js
@@ -168,7 +168,7 @@ module('Acceptance | Course - Publish All Sessions', function (hooks) {
     assert.ok(page.publishAll.isVisible);
     assert.ok(page.publishAll.hasUnlinkedWarning);
 
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
     await m.competencies[0].objectives[0].add();
     await page.details.objectives.objectiveList.objectives[0].parents.save();

diff --git a/packages/frontend/tests/acceptance/course/session/objectiveparents-test.js b/packages/frontend/tests/acceptance/course/session/objectiveparents-test.js
@@ -51,7 +51,7 @@ module('Acceptance | Session - Objective Parents', function (hooks) {
     );
 
     await percySnapshot(getUniqueName(assert, 'default background color'));
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     await percySnapshot(getUniqueName(assert, 'managed background color'));
 
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
@@ -90,7 +90,7 @@ module('Acceptance | Session - Objective Parents', function (hooks) {
     );
 
     await percySnapshot(getUniqueName(assert, 'default background color'));
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     await percySnapshot(getUniqueName(assert, 'managed background color'));
 
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
@@ -142,7 +142,7 @@ module('Acceptance | Session - Objective Parents', function (hooks) {
     );
 
     await percySnapshot(getUniqueName(assert, 'default background color'));
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     await percySnapshot(getUniqueName(assert, 'managed background color'));
 
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;
@@ -194,7 +194,7 @@ module('Acceptance | Session - Objective Parents', function (hooks) {
     );
 
     await percySnapshot(getUniqueName(assert, 'default background color'));
-    await page.details.objectives.objectiveList.objectives[0].parents.list[0].manage();
+    await page.details.objectives.objectiveList.objectives[0].parents.manage();
     await percySnapshot(getUniqueName(assert, 'managed background color'));
 
     const m = page.details.objectives.objectiveList.objectives[0].parentManager;

diff --git a/...n-test-support/ilios-common/page-objects/components/course/objective-list-item-parents.js b/...n-test-support/ilios-common/page-objects/components/course/objective-list-item-parents.js
@@ -2,9 +2,8 @@ import { clickable, create, collection, isHidden, isPresent } from 'ember-cli-pa
 
 const definition = {
   scope: '[data-test-objective-list-item-parents]',
-  list: collection('li', {
-    manage: clickable('[data-test-manage]'),
-  }),
+  list: collection('li'),
+  manage: clickable('[data-test-manage]'),
   empty: isHidden('[data-test-parent]'),
   saveParents: clickable('[data-test-save]'),
   cancelParents: clickable('[data-test-cancel]'),

diff --git a/...-test-support/ilios-common/page-objects/components/session/objective-list-item-parents.js b/...-test-support/ilios-common/page-objects/components/session/objective-list-item-parents.js
@@ -2,9 +2,8 @@ import { clickable, create, collection, isHidden, isPresent } from 'ember-cli-pa
 
 const definition = {
   scope: '[data-test-objective-list-item-parents]',
-  list: collection('li', {
-    manage: clickable('[data-test-manage]'),
-  }),
+  list: collection('li'),
+  manage: clickable('[data-test-manage]'),
   empty: isHidden('[data-test-parent]'),
   saveParents: clickable('[data-test-save]'),
   cancelParents: clickable('[data-test-cancel]'),

diff --git a/packages/test-app/tests/integration/components/course/objective-list-item-parents-test.js b/packages/test-app/tests/integration/components/course/objective-list-item-parents-test.js
@@ -141,6 +141,6 @@ module('Integration | Component | course/objective-list-item-parents', function
   @isSaving={{false}}
   @cancel={{(noop)}}
 />`);
-    await component.list[0].manage();
+    await component.manage();
   });
 });
diff --git a/packages/test-app/tests/integration/components/course/objective-list-item-test.js b/packages/test-app/tests/integration/components/course/objective-list-item-test.js
@@ -78,7 +78,7 @@ module('Integration | Component | course/objective-list-item', function (hooks)
   @manageParents={{this.manageParents}}
 />`,
     );
-    await component.parents.list[0].manage();
+    await component.parents.manage();
     assert.ok(component.parentManager.isPresent);
   });
 

diff --git a/packages/test-app/tests/integration/components/course/objectives-test.js b/packages/test-app/tests/integration/components/course/objectives-test.js
@@ -98,7 +98,7 @@ module('Integration | Component | course/objectives', function (hooks) {
       'course objective 0',
     );
     assert.strictEqual(component.objectiveList.objectives[0].parents.list.length, 1);
-    await component.objectiveList.objectives[0].parents.list[0].manage();
+    await component.objectiveList.objectives[0].parents.manage();
 
     const m = component.objectiveList.objectives[0].parentManager;
     assert.notOk(m.hasMultipleCohorts);
@@ -173,7 +173,7 @@ module('Integration | Component | course/objectives', function (hooks) {
       'course objective 0',
     );
     assert.strictEqual(component.objectiveList.objectives[0].parents.list.length, 1);
-    await component.objectiveList.objectives[0].parents.list[0].manage();
+    await component.objectiveList.objectives[0].parents.manage();
 
     const m = component.objectiveList.objectives[0].parentManager;
     assert.ok(m.hasMultipleCohorts);

diff --git a/packages/test-app/tests/integration/components/session/objective-list-item-parents-test.js b/packages/test-app/tests/integration/components/session/objective-list-item-parents-test.js
@@ -141,7 +141,7 @@ module('Integration | Component | session/objective-list-item-parents', function
   @isSaving={{false}}
   @cancel={{(noop)}}
 />`);
-    await component.list[0].manage();
+    await component.manage();
   });
 
   test('parent objectives are correctly sorted', async function (assert) {

diff --git a/packages/test-app/tests/integration/components/session/objective-list-item-test.js b/packages/test-app/tests/integration/components/session/objective-list-item-test.js
@@ -85,7 +85,7 @@ module('Integration | Component | session/objective-list-item', function (hooks)
   @session={{this.sessionModel}}
 />`,
     );
-    await component.parents.list[0].manage();
+    await component.parents.manage();
     assert.ok(component.parentManager.isPresent);
   });