Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(camel): lazy load camel models #898

Merged
merged 3 commits into from
Apr 25, 2024
Merged

refactor(camel): lazy load camel models #898

merged 3 commits into from
Apr 25, 2024

Conversation

tadayosi
Copy link
Member

Fix #754

@tadayosi tadayosi marked this pull request as draft April 24, 2024 06:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Test Results

  8 files  ±0    8 suites  ±0   47m 27s ⏱️ - 3m 27s
 66 tests ±0   64 ✅ +2   2 💤 ±0  0 ❌  - 2 
536 runs  ±0  508 ✅ +2  28 💤 ±0  0 ❌  - 2 

Results for commit e9038dd. ± Comparison against base commit 9e25ff4.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Apr 24, 2024 •
edited
Loading

Test results

Run attempt: 1553
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 359.489
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 358.209
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 361.48
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 356.179
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 350.144
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 352.151
results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 353.759
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 355.671

@tadayosi tadayosi force-pushed the issue-754-camel-model-lazy-loading branch from 119caad to e170223 Compare April 24, 2024 07:46
@tadayosi
Copy link
Member Author

This should supercede #801 by @mmuzikar

@tadayosi tadayosi marked this pull request as ready for review April 24, 2024 08:03
@tadayosi tadayosi force-pushed the issue-754-camel-model-lazy-loading branch from e170223 to 1b0b1c4 Compare April 24, 2024 10:16
mmuzikar
mmuzikar approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@mmuzikar mmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great!

@tadayosi tadayosi merged commit 745f875 into hawtio:main Apr 25, 2024
13 checks passed
@tadayosi tadayosi mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmuzikar mmuzikar mmuzikar approved these changes

@grgrzybek grgrzybek Awaiting requested review from grgrzybek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider lazy loading of Camel models
2 participants
@tadayosi @mmuzikar