Draft: Setup for improving load times of Hawtio Online #801
Conversation
mmuzikar
force-pushed
the
hawtio-next-754
branch
from
509f41d
to
452f044
Compare
Test resultsRun attempt: 1196
|
Test Results 8 files ±0 8 suites ±0 2h 43m 27s ⏱️ + 2h 1m 48s For more details on these failures, see this check. Results for commit 452f044. ± Comparison against base commit 347d747. ♻️ This comment has been updated with latest results. |
mmuzikar
changed the title
| @@ -333,6 +335,7 @@ export function getCamelVersions(): string[] { | |||
| * the given node. Currently, it supports Camel v3 and v4. | |||
| */ | |||
| export function getCamelModel(node: MBeanNode): CamelModel { | |||
| const { camel4, camel3 } = fetchCamelModules() | |||
There was a problem hiding this comment.
When running I get an error that camel3 is null
There was a problem hiding this comment.
Yeah, rather they should be Promise so that they will never return null.
| @@ -8,6 +8,7 @@ export * from './core' | |||
| export * from './help' | |||
| export * from './plugins' | |||
| export * from './preferences' | |||
| export * from './ui' | |||
| @@ -333,6 +335,7 @@ export function getCamelVersions(): string[] { | |||
| * the given node. Currently, it supports Camel v3 and v4. | |||
| */ | |||
| export function getCamelModel(node: MBeanNode): CamelModel { | |||
| const { camel4, camel3 } = fetchCamelModules() | |||
There was a problem hiding this comment.
Yeah, rather they should be Promise so that they will never return null.
| @@ -23,6 +21,9 @@ import { | |||
| } from './globals' | |||
| import { ROUTE_OPERATIONS } from './routes-service' | |||
|
|
|||
| let _camel3: CamelModel | null = null | |||
| let _camel4: CamelModel | null = null | |||
There was a problem hiding this comment.
so if we change them to Promise them can be const not let.
| camel3: _camel3!, | ||
| camel4: _camel4!, | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this async -> await doesn't work as you expect. Async call is blocked only inside if, which leads to null pointer exception as Paul mentioned because the if block finishes immediately and tries to return the values no matter what values _camel3 and _camel4 have.
| export * from './icons' | ||
| export * from './login' | ||
| export * from './notification' | ||
| export * from './page' |
There was a problem hiding this comment.
Why are they needed? Note that it will change the Hawtio API we expose to external plugin authors. So generally it needs to be justified with a clear reason.
|
Should be fixed with #898. Let's close it. |
Exposed UI components that could be used for unified look of the app (I will use HawtioLoadingPage in Hawtio Online).
Lazy loading Camel models, the fetch starts on the module load and since the both model packages are not included in the resulting bundle it significantly improves the load times.