Change the way docs approvals work #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs PRs are consistently delayed due to the the fact that we currently require two approvals to come from a small team of people who are all very busy. To mitigate this, we will treat PRs that touch docs similarly to PRs that touch code. The new behavior is: 1. PRs continue to require two approvals, whether they touch code, docs, or both. 2. At least one of these two approvals must come from a code "owner" (otherwise known as a "group 1 reviewer"). This becomes the case whether the PR touches docs or not. 3. If the PR does not touch docs, then approvals from the docs reviewers don't count towards the 2 approval limit. 4. If the PR does touch docs, then the docs reviewers are added to group 2 reviewers. Their reviews count towards the two review limit, but their reviews are not required in order to merge the PR.
zmb3
force-pushed
the
zmb3/docs-reviewers
branch
from
b5db9c0
to
00456ca
Compare
zmb3
force-pushed
the
zmb3/docs-reviewers
branch
from
10a6ccd
to
23ee031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs PRs are consistently delayed due to the the fact that we currently require two approvals to come from a small team of people who are all very busy.
To mitigate this, we will treat PRs that touch docs similarly to PRs that touch code. The new behavior is: