Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way docs approvals work #294

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Change the way docs approvals work #294

merged 2 commits into from
Nov 20, 2024

Commits on Nov 18, 2024

  1. Change the way docs approvals work

    Docs PRs are consistently delayed due to the the fact that we currently
    require two approvals to come from a small team of people who are all
    very busy.
    
    To mitigate this, we will treat PRs that touch docs similarly to PRs
    that touch code. The new behavior is:
    
    1. PRs continue to require two approvals, whether they touch code, docs,
       or both.
    2. At least one of these two approvals must come from a code "owner"
       (otherwise known as a "group 1 reviewer"). This becomes the case
       whether the PR touches docs or not.
    3. If the PR does not touch docs, then approvals from the docs reviewers
       don't count towards the 2 approval limit.
    4. If the PR does touch docs, then the docs reviewers are added to group
       2 reviewers. Their reviews count towards the two review limit, but
       their reviews are not required in order to merge the PR.
    zmb3 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    00456ca View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Simplify

    zmb3 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    23ee031 View commit details
    Browse the repository at this point in the history