Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to enable all request methods #127

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Default to enable all request methods #127

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e91e209
Default to enable all request methods
bumi Aug 24, 2023
556a8f4
chore: do not hardcode default selected request methods
rolznz Aug 29, 2023
033e4c8
fix: initialize array
rolznz Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion echo_handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ func (svc *Service) AppsNewHandler(c echo.Context) error {
requestMethods := c.QueryParam("request_methods")
if requestMethods == "" {
//pay_invoice checkbox is default checked but can be disabled
requestMethods = NIP_47_PAY_INVOICE_METHOD
requestMethods = fmt.Sprintf("%s %s %s", NIP_47_GET_BALANCE_METHOD, NIP_47_PAY_INVOICE_METHOD, NIP_47_MAKE_INVOICE_METHOD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should map nip47MethodDescriptions here so we don't need to manually specify them again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know how to do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bumi updated

}
budgetEnabled := maxAmount != "" || budgetRenewal != ""
csrf, _ := c.Get(middleware.DefaultCSRFConfig.ContextKey).(string)
Expand Down
Loading