Default to enable all request methods #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Aug 25, 2023
echo_handlers.go
Outdated
| @@ -250,7 +250,7 @@ func (svc *Service) AppsNewHandler(c echo.Context) error { | |||
| requestMethods := c.QueryParam("request_methods") | |||
| if requestMethods == "" { | |||
| //pay_invoice checkbox is default checked but can be disabled | |||
| requestMethods = NIP_47_PAY_INVOICE_METHOD | |||
| requestMethods = fmt.Sprintf("%s %s %s", NIP_47_GET_BALANCE_METHOD, NIP_47_PAY_INVOICE_METHOD, NIP_47_MAKE_INVOICE_METHOD) | |||
There was a problem hiding this comment.
Maybe we should map nip47MethodDescriptions here so we don't need to manually specify them again?
There was a problem hiding this comment.
I did not know how to do that.
kiwiidb
approved these changes
Aug 31, 2023
|
This does not work for app-created permissions, damn. I will have a look soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is more consitent to enable all (or none) by default..