Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First version of etcd-wrapper #3

Merged
merged 99 commits into from
Jul 11, 2023
Merged

First version of etcd-wrapper #3

merged 99 commits into from
Jul 11, 2023

Conversation

aaronfern
Copy link
Contributor

@aaronfern aaronfern commented Apr 3, 2023 •
edited by unmarshall
Loading

What this PR does / why we need it:
This PR contains the initial code for the first working version of etcd-wrapper
This PR is meant to have etcd-wrapper replicate the functionality of etcd-custom-image and is intended to have etcd-wrapper replace etcd-custom-image

Which issue(s) this PR fixes:
Fixes gardener/etcd-custom-image#16

Special notes for your reviewer:
Please note that documentation and integration tests are a work in progress and are not to be reviewed

Release note:

First version of `etcd-wrapper` which will serve as a replacement for `etcd-custom-image`

@gitguardian
Copy link

gitguardian bot commented Apr 3, 2023 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@aaronfern aaronfern changed the title first version of etcd-wrapper First version of etcd-wrapper Apr 3, 2023
@gardener-robot gardener-robot added the needs/review Needs review label Apr 3, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 3, 2023
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 3, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 3, 2023
@unmarshall
Copy link
Contributor

/invite @shreyas-s-rao @ishan16696 @abdasgupta @seshachalam-yv

@gardener-robot
Copy link
Contributor

@seshachalam-yv, @ishan16696, @shreyas-s-rao, @abdasgupta You have pull request review open invite, please check

@shreyas-s-rao
Copy link
Contributor

/assign

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2023
seshachalam-yv
seshachalam-yv reviewed Apr 13, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
seshachalam-yv
seshachalam-yv requested changes Apr 13, 2023
View reviewed changes
.ci/build Outdated Show resolved Hide resolved
hack/build.sh Show resolved Hide resolved
hack/build.sh Outdated Show resolved Hide resolved
cmd/etcd.go Outdated Show resolved Hide resolved
cmd/help.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Apr 13, 2023
seshachalam-yv
seshachalam-yv requested changes Apr 13, 2023
View reviewed changes
internal/bootstrap/bootstrap.go Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 13, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 13, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 6, 2023
@aaronfern aaronfern added the merge/squash Should be merged via 'Squash and merge' label Jul 7, 2023
ishan16696
ishan16696 requested changes Jul 7, 2023
View reviewed changes
internal/app/readycheck.go Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 10, 2023
ishan16696
ishan16696 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 11, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 11, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unmarshall thanks for the final changes! LGTM 👍
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Jul 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 11, 2023
@unmarshall unmarshall requested a review from a team as a code owner July 11, 2023 04:52
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jul 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 11, 2023
@unmarshall unmarshall merged commit 40c8c89 into main Jul 11, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 11, 2023
@ishan16696 ishan16696 mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall left review comments

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@ishan16696 ishan16696 ishan16696 approved these changes

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@timuthy timuthy Awaiting requested review from timuthy

@abdasgupta abdasgupta Awaiting requested review from abdasgupta

Assignees

@unmarshall unmarshall

@aaronfern aaronfern

Labels
merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement etcd_bootstrap_script.sh in Golang
10 participants
@aaronfern @unmarshall @gardener-robot @shreyas-s-rao @ishan16696 @abdasgupta @seshachalam-yv @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3