Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing the ReadinessProbe discussion with GET call using --consistency=linearizable #13

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Closing the ReadinessProbe discussion with GET call using --consistency=linearizable #13

merged 1 commit into from
Aug 16, 2023

Conversation

ishan16696
Copy link
Member

@ishan16696 ishan16696 commented Aug 16, 2023 •
edited
Loading

What this PR does / why we need it:
This PR closes the readinessProbe discussion which were discussed in this thread: here and here
As decided, readinessProbe should reflect the readinessProbe of cluster(quorum or --consistency=linearizable) ready to accept client traffic not readiness of each member (--consistency=serializable)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

None

@ishan16696 ishan16696 requested a review from a team as a code owner August 16, 2023 09:06
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 16, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2023
@shreyas-s-rao shreyas-s-rao added this to the v0.2.0 milestone Aug 16, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 16, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 16, 2023
@ishan16696 ishan16696 merged commit b7c30d5 into gardener:main Aug 16, 2023
1 check passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 16, 2023
@ishan16696 ishan16696 deleted the closeReadinessProbeDiscussion branch August 16, 2023 15:11
ishan16696 added a commit to ishan16696/etcd-wrapper that referenced this pull request Jan 2, 2024
@ishan16696
Closing the ReadinessProbe discussion with GET call using --consisten…
8f9128b 
…cy=linearizable. (gardener#13)
@ishan16696 ishan16696 mentioned this pull request Jan 2, 2024
Merged
ishan16696 added a commit that referenced this pull request Jan 2, 2024
@ishan16696
Closing the ReadinessProbe discussion with GET call using --consisten…
6998268 
…cy=linearizable. (#13) (#23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ishan16696 @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot