Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change introduction to field type Text Editor on Appointment Letter && Appointment Letter Template #824

Closed
wants to merge 1 commit into from
Closed

feat: change introduction to field type Text Editor on Appointment Letter && Appointment Letter Template #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hrms/patches.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ hrms.patches.v14_0.create_custom_field_for_appraisal_template
hrms.patches.post_install.update_performance_module_changes #2023-04-17
hrms.patches.v14_0.update_ess_user_access #2023-08-14
execute:frappe.db.set_default("date_format", frappe.db.get_single_value("System Settings", "date_format"))
hrms.patches.v14_0.create_vehicle_service_item
hrms.patches.v14_0.create_vehicle_service_item
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need to change field type by editing the doctype directly. Patch isn't required here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. This happens for standard fields though.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh okay. Actually, both the field types create a longtext column in DB. So this transition should be allowed IG.
Description is a Text Editor field. Introduction is Long Text

image

But the quill editor adds a div enclosing the content. Maybe that's why the transition is not allowed.

image

Will have to check the framework. Closing this for now. Adding a patch won't help.

hrms.patches.v14_0.change_appointment_letter_introduction_to_texteditor #28th August 2023
22 changes: 22 additions & 0 deletions hrms/patches/v14_0/change_appointment_letter_introduction_to_texteditor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import frappe

def execute():
try:
doc_types = ['Appointment Letter', 'Appointment Letter Template']

field_name = 'introduction'

for doc_type in doc_types:
meta = frappe.get_meta(doc_type)

if field_name in [field.fieldname for field in meta.fields]:
for field in meta.fields:
if field.fieldname == field_name:
field.fieldtype = 'Text Editor'
field.save()
break
else:
print(f"Field '{field_name}' not found in '{doc_type}' DocType.")

except Exception as e:
print(f"Error: {e}")
Loading