feat: change introduction to field type Text Editor on Appointment Letter && Appointment Letter Template
#824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`Appointment Letter Template` change datatype from `Data` to `Text Editor` to provide more editing options
| hrms.patches.v14_0.create_vehicle_service_item | ||
| hrms.patches.v14_0.change_appointment_letter_introduction_to_texteditor #28th August 2023 |
There was a problem hiding this comment.
You just need to change field type by editing the doctype directly. Patch isn't required here.
There was a problem hiding this comment.
Ok. This happens for standard fields though.
There was a problem hiding this comment.
Ohh okay. Actually, both the field types create a longtext column in DB. So this transition should be allowed IG.
Description is a Text Editor field. Introduction is Long Text
But the quill editor adds a div enclosing the content. Maybe that's why the transition is not allowed.
Will have to check the framework. Closing this for now. Adding a patch won't help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction field on
Appointment LetterandAppointment Letter Templatea data field type providing no styling options.Previously:
After change:
Closes: #774