Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta build #62

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Beta build #62

wants to merge 26 commits into from

Conversation

MerujSargsyan
Copy link
Collaborator

I have implemented the major features for the machines DFA, NFA and Turing, and I have placed some of the tests I have done inside a PDF within the test repository. Although I have found these bugs, they are a relatively minor or rare case, which although I do plan to correct, I think it is a good time to try it. If you would like me to completely fix all bugs before committing please let me know @Lexseal !

@Lexseal
Copy link
Member

Lexseal commented Dec 2, 2024

Woah thank you so much for your fantastic work! It's so cool!

I am guessing you were referring to 1) state names overlapping the diagram and 2) self-loops labels overlapping each other?

Do you have any suggestions on how to fix these two issues? I think self-loops will be quite common so it's more of an issue. IIRC in our textbook they use the shorthand notation, combining the labels. Is that something you can implement?

@Lexseal Lexseal self-requested a review December 2, 2024 02:52
@MerujSargsyan
Copy link
Collaborator Author

To be honest, I think the self loops are very doable, I simply need time to understand how exactly the angles are computed in the web application in order to translate them as relative position (above, right, left, below.) And about the more complicated state labels I would have to look if tikz picture has a mode where it simply takes the label name as text instead of latex input.

I will quickly fix the linter errors asap!

@Lexseal
Copy link
Member

Lexseal commented Dec 2, 2024

okay great! The two angles are where the mouse pointer leaves and re-enters the node. The angle is in rad and counter-clockwise. Suppose the mouse lefts the node at 3 o'clock, the angle will be 0. If the mouse re-enters at 12 o'clock, the angle will be pi/2.

Does this help?

@Lexseal
Copy link
Member

Lexseal commented Dec 2, 2024

Will take a closer look tomorrow

@Lexseal
Copy link
Member

Lexseal commented Dec 2, 2024

Also sorry about the linter. I believe you can run it locally too. Try npm run lint : )

@MerujSargsyan
Copy link
Collaborator Author

I removed the no useless escape rule because it thought "\begin" was using an unecessary escape. Am I clear to merge the branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants