Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #894

Merged
merged 8 commits into from
Nov 4, 2024
2 changes: 1 addition & 1 deletion docs/source/userguide/beginners_guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ To make the most out of FESTIM, a basic knowledge of `Python <https://www.learnp

Depending on how you install FESTIM, new users should familiarise with either `Docker <https://www.docker.com/>`_ or `Conda <https://anaconda.org/>`_.

FESTIM is under version control with `git <https://git-scm.com/>`_. Even though users don't need git to install FESTIM, it is convenient to have a basic understanding of how it works. You can fin `git turorials <https://git-scm.com/doc>`_ to help you getting started. The `FESTIM source code <https://github.com/RemDelaporteMathurin/FESTIM>`_ is hosted on GitHub. It is recommended to sign up for free to GitHub in order to receive the latest updates, follow the development and submit `bug reports <https://github.com/RemDelaporteMathurin/FESTIM/issues/new/choose>`_.
FESTIM is under version control with `git <https://git-scm.com/>`_. Even though users don't need git to install FESTIM, it is convenient to have a basic understanding of how it works. You can fin `git turorials <https://git-scm.com/doc>`_ to help you getting started. The `FESTIM source code <https://github.com/RemDelaporteMathurin/FESTIM>`_ is hosted on GitHub. Git knowledge and a GitHub account is required to open issues and contribute to the code.
RemDelaporteMathurin marked this conversation as resolved.
Show resolved Hide resolved

----------------------
Where can I find help?
Expand Down
2 changes: 0 additions & 2 deletions festim/hydrogen_transport_problem.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ class HydrogenTransportProblem(F.ProblemBase):
of the model
boundary_conditions (list of festim.BoundaryCondition): the boundary
conditions of the model
solver_parameters (dict): the solver parameters of the model
exports (list of festim.Export): the exports of the model
traps (list of F.Trap): the traps of the model

Expand All @@ -39,7 +38,6 @@ class HydrogenTransportProblem(F.ProblemBase):
of the model
boundary_conditions (list of festim.BoundaryCondition): the boundary
conditions of the model
solver_parameters (dict): the solver parameters of the model
exports (list of festim.Export): the exports of the model
traps (list of F.Trap): the traps of the model
dx (dolfinx.fem.dx): the volume measure of the model
Expand Down
1 change: 1 addition & 0 deletions festim/problem.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ def run(self):
# Solve steady-state
self.solver.solve(self.u)
self.post_processing()
self.progress_bar.close()
RemDelaporteMathurin marked this conversation as resolved.
Show resolved Hide resolved

def iterate(self):
"""Iterates the model for a given time step"""
Expand Down
Loading