Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #894

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Conversation

kaelyndunnell
Copy link
Contributor

@kaelyndunnell kaelyndunnell commented Oct 11, 2024

Proposed changes

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (2930d8d) to head (7a770bc).
Report is 9 commits behind head on fenicsx.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #894   +/-   ##
========================================
  Coverage    97.75%   97.76%           
========================================
  Files           44       44           
  Lines         2098     2099    +1     
========================================
+ Hits          2051     2052    +1     
  Misses          47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin changed the title Removed out of date line in docstrings addressing issue #684 Documentation updates Oct 12, 2024
Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaelyndunnell for this contribution! You modified the fenicsx branch, however we would like to see this documentation change (what do I need to know) on main too

Could you open another PR to add this change to the main branch too please?

docs/source/userguide/beginners_guide.rst Outdated Show resolved Hide resolved
festim/problem.py Outdated Show resolved Hide resolved
@RemDelaporteMathurin RemDelaporteMathurin changed the title Documentation updates Various fixes Oct 24, 2024
@RemDelaporteMathurin RemDelaporteMathurin added the fenicsx Issue that is related to the fenicsx support label Oct 30, 2024
@RemDelaporteMathurin RemDelaporteMathurin merged commit db4ad6f into festim-dev:fenicsx Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation fenicsx Issue that is related to the fenicsx support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HydrogenTransportProblem docstrings out-of-date [BUG] dolfinx MPI_ABORT due to tqdm progress bar
2 participants