-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(polka-storage-proofs): add sector padding #434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th7nder
force-pushed
the
fix/420/multiple-pieces
branch
2 times, most recently
from
October 8, 2024 12:49
94fb211
to
dc44944
Compare
jmg-duarte
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions, overall looks good. Nice job 🚀
th7nder
force-pushed
the
fix/420/multiple-pieces
branch
from
October 8, 2024 13:54
dc44944
to
f2989f5
Compare
jmg-duarte
previously approved these changes
Oct 8, 2024
th7nder
force-pushed
the
fix/420/multiple-pieces
branch
from
October 8, 2024 14:01
f2989f5
to
34724fe
Compare
th7nder
force-pushed
the
fix/420/multiple-pieces
branch
from
October 9, 2024 05:55
34724fe
to
43f817a
Compare
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Oct 9, 2024
cernicc
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
jmg-duarte
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #420.
Sector file is always full-sized one, no matter how many pieces are inside.
To generate a valid CommD from pieces, so a proof can be generated, we need to pad the sector with 'dummy' pieces so the CommD calculation from pieces is the same as the one from raw disk data.
This PR allows to create a Sector via
create_sector
function from pieces which do not take the entire space of the sector.Important points for reviewers
When implementing #360 (or merging #423), the interface will probably need to be changed a bit so it accomodates use cases outside the PoRep Demo.
I didn't want to make it now, cause i don't know the shape of a client yet.
Checklist