Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use padding in add_piece? #436

Open
Tracked by #522
th7nder opened this issue Oct 8, 2024 · 1 comment
Open
Tracked by #522

Don't use padding in add_piece? #436

th7nder opened this issue Oct 8, 2024 · 1 comment
Labels
tech debt Flags technical debt
Milestone

Comments

@th7nder
Copy link
Contributor

th7nder commented Oct 8, 2024

          The alternative [`write_and_preprocess`](https://github.com/filecoin-project/rust-fil-proofs/blob/266acc39a3ebd6f3d28c6ee335d78e2b7cea06bc/filecoin-proofs/src/api/mod.rs#L502) just calls `add_pieces` and forces it to not add a padding, so the whole responsibility falls on the sealing logic and the pipeline. I'd say I'm fine for now with this padding and losing a bit of space, to reduce the complexity of other logic.

Originally posted by @th7nder in #434 (comment)

@th7nder th7nder added this to the Phase 2 milestone Oct 8, 2024
@jmg-duarte
Copy link
Collaborator

Moving to after P3, currently this works so there's no point in changing right now

@jmg-duarte jmg-duarte removed this from the Phase 2 milestone Nov 4, 2024
@th7nder th7nder mentioned this issue Nov 7, 2024
8 tasks
@th7nder th7nder added this to the Phase 3 milestone Nov 13, 2024
@jmg-duarte jmg-duarte added the tech debt Flags technical debt label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Flags technical debt
Projects
None yet
Development

No branches or pull requests

2 participants