Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF-5140 Adds @Nullable & @Nonnull annotations to generated data model getters #527

Merged
merged 11 commits into from
Mar 19, 2024
Merged

MF-5140 Adds @Nullable & @Nonnull annotations to generated data model getters #527

merged 11 commits into from
Mar 19, 2024

Conversation

wdziemia
Copy link
Contributor

@wdziemia wdziemia commented Mar 6, 2024 •
edited
Loading

Adds JSR-305 for its annotations to mark getter accessors of data models as nonnull or null

@wdziemia wdziemia self-assigned this Mar 6, 2024
wdziemia
wdziemia commented Mar 14, 2024
View reviewed changes
core/build.gradle Outdated Show resolved Hide resolved
rharter
rharter approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@rharter rharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. For complete correctness, I might consider adding the annotation to the backing protected fields as well, but don't think that should hold things up.

@wdziemia wdziemia merged commit 98daa3d into main Mar 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devPalacio devPalacio devPalacio approved these changes

@rharter rharter rharter approved these changes

@chris-mitchell chris-mitchell Awaiting requested review from chris-mitchell

Assignees

@wdziemia wdziemia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wdziemia @rharter @devPalacio