MF-5140 Adds @nullable & @nonnull annotations to generated data model…

… getters
dropbox · Mar 6, 2024 · a8762f3 · a8762f3
1 parent 9d3744c
commit a8762f3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/core/build.gradle b/core/build.gradle
@@ -57,6 +57,7 @@ sourceSets.main.java.srcDir(versionWriterTask)
 dependencies {
     api(dropboxJavaSdkLibs.jackson.core)
 
+    compileOnly dropboxJavaSdkLibs.jsr305
     compileOnly dropboxJavaSdkLibs.appengine.api
     compileOnly dropboxJavaSdkLibs.jakarta.servlet.api
     compileOnly dropboxJavaSdkLibs.kotlin.stdlib

diff --git a/core/generator/java/java.stoneg.py b/core/generator/java/java.stoneg.py
@@ -3433,6 +3433,12 @@ def generate_data_type_struct(self, data_type):
                     returns += ' Defaults to %s.' % w.java_default_value(field)
 
                 w.javadoc(field.doc or '', stone_elem=field, returns=returns)
+
+                if not field.has_default and field in data_type.all_optional_fields:
+                    w.out('@javax.annotation.Nullable')
+                elif not j.is_java_primitive(field.data_type):
+                    w.out('@javax.annotation.Nonnull')
+
                 with w.block('public %s %s()', j.java_class(field), j.field_getter_method(field)):
                     w.out('return %s;' % j.param_name(field))
 

diff --git a/gradle/dropboxJavaSdkLibs.versions.toml b/gradle/dropboxJavaSdkLibs.versions.toml
@@ -29,6 +29,7 @@ jackson-databind = 'com.fasterxml.jackson.core:jackson-databind:2.15.0'
 jetty-server = "org.eclipse.jetty:jetty-server:11.0.15"
 json = "org.json:json:20230618"
 jakarta-servlet-api = 'jakarta.servlet:jakarta.servlet-api:5.0.0'
+jsr305 = 'com.google.code.findbugs:jsr305:3.0.2'
 kotlin-gradle-plugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
 kotlin-stdlib = { module = "org.jetbrains.kotlin:kotlin-stdlib", version.ref = "kotlin" }
 kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotlin" }