-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Spans and ReadOnlyCollection.Empty in TextBlock/Line, reduce allocs #9993
Open
h3xds1nz
wants to merge
14
commits into
dotnet:main
Choose a base branch
from
h3xds1nz:minor-textblock-stuff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new List<Rect>(0))
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
October 24, 2024 21:43
dotnet-policy-service
bot
added
PR
metadata: Label to tag PRs, to facilitate with triage
Community Contribution
A label for all community Contributions
labels
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bringing some optimizations to
TextBlock
control and related components (Line
;ComplexLine
).Initialize
method in TextBlock'sctor
has been removed.GetLineIndexFromDcp
andClearComplexContent
have been removed (EnsureComplexContent
handles the detach if its needed)new ReadOnlyCollection<T>(new List<T>(0))
numerous times, we swap to the non-allocating, generic singleton variant ofReadOnlyCollection<T>.Empty
, removing all possible overhead.ArrayList
forInlineObjects
inComplexContent
withList<InlineObject>
.ComplexLine
-double adjustedXOffset
(method doesn't modify state either)AlignContent
-Vector contentOffset
(method doesn't modify state either)GetRangeBounds
inLine
instead of using aList<Rect>
now uses pre-allocatedRect[]
that's wrapped inReadOnlySpan<Rect>
to its callers on return.List<TextSegment>(1)
and usingInsert
(that's a great combination), we useTextSegment[]
.GetTightBoundingGeometryFromTextPositions
with more thoughtful impl.new
ReadOnlyCollection<T>(new List<T>(0))
vsEmpty
GetRangeBounds
call old vs. new and the loop itself; without combining geometriesGetTightBoundingGeometryFromTextPositions inner loop (1 rect)
Customer Impact
Increased performance, decreased allocations.
Regression
No.
Testing
Local build, sample apps run.
Risk
Should be low, the changes are pretty much mechanical.
Microsoft Reviewers: Open in CodeFlow