Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Spans and ReadOnlyCollection.Empty in TextBlock/Line, reduce allocs #9993

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Use Spans and ReadOnlyCollection.Empty in TextBlock/Line, reduce allocs #9993

wants to merge 14 commits into from

Commits on Oct 23, 2024

  1. Use ReadOnlyCollection<Rect>.Empty over new ReadOnlyCollection<Rect>(… 

    …new List<Rect>(0))
    @h3xds1nz
    h3xds1nz committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    dcea7bc View commit details
    Browse the repository at this point in the history

  2. Pre-allocate the List<Rect> in GetRangeBounds

    @h3xds1nz
    h3xds1nz committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d96501d View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Use ReadOnlyCollection<TextSegment>.Empty and stop creating a List<Te… 

    …xtSegment>(1)
    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    776f37d View commit details
    Browse the repository at this point in the history

  2. Easy pattern-matching

    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    973d7cd View commit details
    Browse the repository at this point in the history

  3. Remove uncalled CalcContentOffset in AlignContent

    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a42a69b View commit details
    Browse the repository at this point in the history

  4. Remove uncalled dead code

    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a55a15d View commit details
    Browse the repository at this point in the history

  5. Remove empty Initialize function

    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    adf5963 View commit details
    Browse the repository at this point in the history

  6. Use ReadOnlySpan<Rect>/Rect[] combo over (I)List<Rect>, simplify and … 

    …speed up loop
    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e94f222 View commit details
    Browse the repository at this point in the history

  7. Mark CalcLineAdvance as static and swap params

    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    96de88a View commit details
    Browse the repository at this point in the history

  8. Remove double null assigment to ie in InputHitTestCore

    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    3bffc26 View commit details
    Browse the repository at this point in the history

  9. Swap ArrayList for List<InlineObject>

    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9859041 View commit details
    Browse the repository at this point in the history

  10. Remove unused LineOffset calculation in ComplexLine.Arrange; use patt… 

    …ern-match
    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    231af1d View commit details
    Browse the repository at this point in the history

  11. Remove warning suppressions in HostedElements and seal the class

    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7a56976 View commit details
    Browse the repository at this point in the history

  12. Remove a comment

    @h3xds1nz
    h3xds1nz committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2d33492 View commit details
    Browse the repository at this point in the history