-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implicit reference to Microsoft.AspNetCore.App.Internal.Assets
#44997
Conversation
Tested locally by building a local version of the SDK, manually making changes to the generated |
<KnownAspNetCorePack Include="Microsoft.AspNetCore.App.Internal.Assets" | ||
TargetFramework="net10.0" | ||
AspNetCorePackVersion="$(MicrosoftAspNetCoreAppRuntimePackageVersion)" /> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only part I'm not 100% sure about. You can have an SDK and multiple runtimes. Meaning that you can have an install that has 1.0.0, 1.0.1, and 1.0.2 installed. 1.0.2 might be bundled, but your app might be using <FrameworkReference="Microsoft.AspNetCore.App" Version="1.0.0" />
or have it pinned in the global.json
.
In that case shouldn't we respect that?
@maraf do you have any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that when we are building an app, we are always using the bundled versions; otherwise the rest of the items wouldn't work correctly as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maraf but it depends on whether you are pinning explicitly to a previous runtime, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this for now
Follow up to dotnet/aspnetcore#58721