-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix source build when using --no-build-js
#59118
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need --no-build-nodejs
for source build, isn't that the case?
Can we not instead update the check so that in that situation just disable the check that triggers the error when we are running inside source build?
Source build doesn't run any code, it just builds it, and the JS assets are not needed for the build step.
Yeah, that sounds good. I'll update this PR to disable the check if not building with NodeJS. Eventually I think we'll want to change |
1a85202
to
96ec852
Compare
blazor.webview.js
check when not building NodeJS
96ec852
to
bb889c5
Compare
bb889c5
to
0ea2f25
Compare
blazor.webview.js
check when not building NodeJS--no-build-js
blazor.webview.js
Microsoft.AspNetCore.App.Internal.Assets
to build successfully when using--no-build-js
, even when the framework JS assets are not on diskFixes #59114