-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build installers at the end of the repo build and allow building with desktop msbuild #58987
Conversation
Adding the NO MERGE label until I fully tested the changes inside the VMR |
4de0a68
to
acd5702
Compare
Local Development job failures are unrelated |
ec997da
to
1504eaf
Compare
@ellahathaway this will fix the Sign and Publish issue as well inside the VMR. |
1eb05c2
to
10a83ad
Compare
1d6cb7c
to
de94095
Compare
4e3b499
to
dd10a42
Compare
4c4051e
to
e980b37
Compare
56be416
to
8f18412
Compare
Enables building the aspnetcore repo with a single eng\build.cmd invocation (when using desktop msbuild). Unblocks dotnet/sdk#44828 & dotnet/aspnetcore#58987
Needs #59150 |
Co-authored-by: William Godbe <wigodbe@microsoft.com>
Is there any reason we can't update the Windows build in ci/ci-public.yml to use the new one-pass build.cmd invocation you mentioned on Teams? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
If you are OK with building everything with desktop msbuild, sure. From reading some of the comments in the build.ps1 file, that doesn't seem to be the case though. I filed #59151 to track whether |
Fixes #58984
Unblocks dotnet/sdk#44828 (removes the patch)
Depends on #59150
BuildStep
metadata.{PR title}
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)