Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Inputs&Outputs from GenerateDirectoryBuildFiles #59164

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 26, 2024

Fixes the broken official builds. Regressed with #58987

My assumption is that the targets is invoked again in a later stage and the inputs & outputs hinder it from re-generating the file.

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Fixes the broken official builds.

My assumption is that the targets is invoked again in a later stage and the inputs & outputs hinder it from re-generating the file.
@ViktorHofer ViktorHofer requested review from wtgodbe and a team as code owners November 26, 2024 10:46
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 26, 2024
@ViktorHofer ViktorHofer enabled auto-merge (squash) November 26, 2024 10:47
@ViktorHofer ViktorHofer merged commit 764eb46 into main Nov 26, 2024
27 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch November 26, 2024 13:13
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants