Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEAB-5604: fix date for the github lambda bucket #163

Merged
merged 2 commits into from
Apr 19, 2024
Merged

SEAB-5604: fix date for the github lambda bucket #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
270c342
fix date
hyunnaye Apr 19, 2024
a95b279
eslint
hyunnaye Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion upsertGitHubTag/deployment/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,9 @@ function logPayloadToS3(body, deliveryId) {
// If bucket name is not null (had to put this for the integration test)
if (process.env.BUCKET_NAME) {
const uploadDate = new Date();
const bucketPath = `${uploadDate.getFullYear()}-${uploadDate.getMonth()}-${uploadDate.getDay()}/${deliveryId}`; //formats path to YYYY-MM-DD/deliveryid
const bucketPath = `${uploadDate.getFullYear()}
-${uploadDate.getMonth() + 1}
-${uploadDate.getDate()}/${deliveryId}`; //formats path to YYYY-MM-DD/deliveryid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth double-checking that the date is 0 or 1 indexed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date seems to be 1 indexed from this info: https://www.freecodecamp.org/news/javascript-get-current-date-todays-date-in-js/


const command = new PutObjectCommand({
Bucket: process.env.BUCKET_NAME,
Expand Down
Loading