SEAB-5604: fix date for the github lambda bucket #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathy-t
approved these changes
Apr 19, 2024
denis-yuen
approved these changes
Apr 19, 2024
| const bucketPath = `${uploadDate.getFullYear()}-${uploadDate.getMonth()}-${uploadDate.getDay()}/${deliveryId}`; //formats path to YYYY-MM-DD/deliveryid | ||
| const bucketPath = `${uploadDate.getFullYear()} | ||
| -${uploadDate.getMonth() + 1} | ||
| -${uploadDate.getDate()}/${deliveryId}`; //formats path to YYYY-MM-DD/deliveryid |
There was a problem hiding this comment.
Worth double-checking that the date is 0 or 1 indexed?
There was a problem hiding this comment.
The date seems to be 1 indexed from this info: https://www.freecodecamp.org/news/javascript-get-current-date-todays-date-in-js/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed the events in the new github s3 bucket is creating folders with a wrong current date.
This was because the
getMonthfunction is zero-index based so we have to add 1 to get the correct month.Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5604
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!