Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style] SectionTitle 컴포넌트 스타일 수정 #281

Merged
merged 3 commits into from
Sep 22, 2023
Merged

[Style] SectionTitle 컴포넌트 스타일 수정 #281

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
873f125
fix: optional desc 적용
Sep 21, 2023
b0ebb49
fix: 설명 있을때만 돔 생성
Sep 21, 2023
47f61a7
fix: 윤호님 리뷰 적용
sumi-0011 Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/SectionTitle/SectionTitle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function SectionTitle({ label, title, description, ...layoutProps }: Sect
<div css={layoutCss} {...layoutProps}>
<h4 css={labelCss}>{label}</h4>
<h2 css={titleCss}>{title}</h2>
Copy link
Member

@kimyouknow kimyouknow Sep 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나머지 친구들도 같은 맥락으로 이렇게 하는 건 어때요?? title, label이 항상 쓰여서 별 의미는 없지만 나중에 같은 문제를 일으킬 수도 있을 것 같아요!

Suggested change
<h4 css={labelCss}>{label}</h4>
<h2 css={titleCss}>{title}</h2>
{label && <h4 css={labelCss}>{label}</h4>}
{title && <h2 css={titleCss}>{title}</h2>}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

적용했습니다!

<p css={descriptionCss}>{description}</p>
{description && <p css={descriptionCss}>{description}</p>}
</div>
);
}
Expand Down
Loading