-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Style] SectionTitle 컴포넌트 스타일 수정 #281
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle SizesCompared against d4bc7f9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
놓친 부분 있었네요 감사합니다🙇🏻
<h4 css={labelCss}>{label}</h4> | ||
<h2 css={titleCss}>{title}</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나머지 친구들도 같은 맥락으로 이렇게 하는 건 어때요?? title, label이 항상 쓰여서 별 의미는 없지만 나중에 같은 문제를 일으킬 수도 있을 것 같아요!
<h4 css={labelCss}>{label}</h4> | |
<h2 css={titleCss}>{title}</h2> | |
{label && <h4 css={labelCss}>{label}</h4>} | |
{title && <h2 css={titleCss}>{title}</h2>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
적용했습니다!
작업 내용
설명 props를 넘기지 않아도 dom이 렌더링되어 공간을 차지하는 문제였습니다.
스크린샷
as is
to be