Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] SectionTitle 컴포넌트 스타일 수정 #281

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

sumi-0011
Copy link
Member

작업 내용

  • SectionTitle 아래 공백이 이상하게 많은 것 같아 확인해보니,
    설명 props를 넘기지 않아도 dom이 렌더링되어 공간을 차지하는 문제였습니다.
  • 설명 props가 있을 때만 돔을 렌더링하게해서 수정했습니다.

스크린샷

as is

image

to be

image

@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 4:13pm

@github-actions github-actions bot added style change style or request it workflow Change for workflow labels Sep 21, 2023
@sumi-0011 sumi-0011 changed the base branch from main to develop September 21, 2023 03:23
@github-actions github-actions bot removed style change style or request it workflow Change for workflow labels Sep 21, 2023
@sumi-0011 sumi-0011 added the style change style or request it label Sep 21, 2023
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Bundle Sizes

Compared against d4bc7f9

Route Size (gzipped) Diff
/ 75.35 KB -6.91 KB
/404 71.89 KB -4.91 KB
/_app 118.2 KB -12.72 KB
/about 72.2 KB -12.73 KB
/project 78.15 KB -16.71 KB
/recruit 110.89 KB +25.66 KB
/contact no change removed
/project/[projectTitle] no change removed
/recruit/[position] no change removed
Dynamic import Size (gzipped) Diff
../components/project-detail/OtherProjectSection.tsx -> ../project/ProjectItem/ProjectItem no change removed

@github-actions
Copy link

@github-actions
Copy link

Copy link
Member

@kimyouknow kimyouknow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

놓친 부분 있었네요 감사합니다🙇🏻

Comment on lines 18 to 19
<h4 css={labelCss}>{label}</h4>
<h2 css={titleCss}>{title}</h2>
Copy link
Member

@kimyouknow kimyouknow Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나머지 친구들도 같은 맥락으로 이렇게 하는 건 어때요?? title, label이 항상 쓰여서 별 의미는 없지만 나중에 같은 문제를 일으킬 수도 있을 것 같아요!

Suggested change
<h4 css={labelCss}>{label}</h4>
<h2 css={titleCss}>{title}</h2>
{label && <h4 css={labelCss}>{label}</h4>}
{title && <h2 css={titleCss}>{title}</h2>}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

적용했습니다!

@github-actions
Copy link

@sumi-0011 sumi-0011 merged commit 860d4ad into develop Sep 22, 2023
10 checks passed
@sumi-0011 sumi-0011 deleted the fix/schedule-title-style branch September 22, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants