Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate to German #174

Merged
merged 12 commits into from
May 25, 2024
Merged

Translate to German #174

merged 12 commits into from
May 25, 2024

Conversation

dbrgn
Copy link
Owner

@dbrgn dbrgn commented May 17, 2024 •
edited
Loading

Integrate i18next to make the website translatable.

Fixes #173.

To do:

  • Add a mechanism for having markup in the translation string
  • Check translations in CI
  • Translate all strings to German
  • Add language switcher

@dbrgn dbrgn added the enhancement New feature or request label May 17, 2024
@dbrgn dbrgn self-assigned this May 17, 2024
@socket-security Socket Security
Copy link

socket-security bot commented May 17, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/i18next-icu@2.3.0 None +6 2.25 MB adrai
npm/i18next-parser@8.13.0 Transitive: environment, eval, filesystem, network, shell, unsafe +144 232 MB karellm
npm/i18next@23.11.4 None +2 926 kB adrai

View full report↗︎

@dbrgn dbrgn force-pushed the 173-i18n branch 2 times, most recently from bb9d433 to 534a4ae Compare May 18, 2024 21:34
@dbrgn dbrgn changed the title Make website translatable Translate to German May 19, 2024
@dbrgn dbrgn force-pushed the 173-i18n branch 2 times, most recently from e0be5d2 to 5d2276e Compare May 24, 2024 21:23
@dbrgn dbrgn marked this pull request as ready for review May 25, 2024 17:39
@dbrgn
Copy link
Owner Author

dbrgn commented May 25, 2024

Phew, that was much more work than expected...

@dbrgn dbrgn enabled auto-merge May 25, 2024 17:58
@dbrgn dbrgn merged commit 16e7126 into main May 25, 2024
11 checks passed
@dbrgn dbrgn deleted the 173-i18n branch May 25, 2024 17:58
@dbrgn dbrgn mentioned this pull request May 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dbrgn dbrgn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internationalization / Translation
1 participant
@dbrgn