Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: No need in the Builder::add_resource taking ownership of the resource stream; use reference instead #479

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

fix: No need in the Builder::add_resource taking ownership of the resource stream; use reference instead #479

wants to merge 18 commits into from

Commits on Jun 6, 2024

  1. Don't take ownership of the resource stream, since the reference is o… 

    …nly needed.
    @brogdonm
    brogdonm committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    aba36ce View commit details
    Browse the repository at this point in the history

  2. Remove the Seek requirement on the resource stream, only used for r… 

    …eading
    @brogdonm
    brogdonm committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7b7557f View commit details
    Browse the repository at this point in the history

  3. Keep the use of 'impl' instead of a generic parameter

    @brogdonm
    brogdonm committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    bfc0900 View commit details
    Browse the repository at this point in the history

  4. Fix code formatting.

    @brogdonm
    brogdonm committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5af28e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c34d68d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7055d3f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8961f25 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b845ae9 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    991d75e View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b08a71d View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    61eaafa View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6ea7d2a View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    cb827cd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7453db1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5905cf6 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    85f45c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    dd0e2a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge branch 'main' into fix/iconResourceTakeARef

    @brogdonm
    brogdonm authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    071b1e1 View commit details
    Browse the repository at this point in the history