Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

1116 init validation solidity v0.6 #1124

Closed
wants to merge 29 commits into from
Closed

1116 init validation solidity v0.6 #1124

wants to merge 29 commits into from

Commits on May 10, 2020

  1. plock

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    bad4625 View commit details
    Browse the repository at this point in the history

  2. Update solc version to be used by buidler to 0.6.7

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    1dd7523 View commit details
    Browse the repository at this point in the history

  3. Compile against default EVM

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    c75014c View commit details
    Browse the repository at this point in the history

  4. Update @openzeppelin/contracts to 3.0.1

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    2bdf850 View commit details
    Browse the repository at this point in the history

  5. plock

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    d7a8fef View commit details
    Browse the repository at this point in the history

  6. Update compiler version pragma to 0.6.7 

    ... in every Solidity source file.
    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    15375e3 View commit details
    Browse the repository at this point in the history

  7. Fix fallback function syntax in Proxy

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    665e312 View commit details
    Browse the repository at this point in the history

  8. Replace remaining fallback functions with receive

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    42f813a View commit details
    Browse the repository at this point in the history

  9. Replace gas with gas() in assembly

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    1a94f79 View commit details
    Browse the repository at this point in the history

  10. Rename variable in assembly 

    ... to prevent shadowing the state variable with the same name.
    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    424f349 View commit details
    Browse the repository at this point in the history

  11. Add name to NatSpec @returns where needed

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    badb0c9 View commit details
    Browse the repository at this point in the history

  12. Add virtual and override keywords where necessary

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    f008c04 View commit details
    Browse the repository at this point in the history

  13. Fix DolphinCoin

    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    c939e24 View commit details
    Browse the repository at this point in the history

  14. Fix broken tests 

    OpenZeppelin's ECDSA library now reverts more aggressively, so there
were some mismatches in revert messages.
    @HeikoFisch
    HeikoFisch committed May 10, 2020
    Configuration menu
    Copy the full SHA
    3c993c2 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Get rid of "Unused local variable." warnings

    @HeikoFisch
    HeikoFisch committed May 11, 2020
    Configuration menu
    Copy the full SHA
    2c572f1 View commit details
    Browse the repository at this point in the history

  2. Get rid of "Unused function parameter." warnings

    @HeikoFisch
    HeikoFisch committed May 11, 2020
    Configuration menu
    Copy the full SHA
    c87433a View commit details
    Browse the repository at this point in the history

  3. Get rid of some warnings to restrict state mutability

    @HeikoFisch
    HeikoFisch committed May 11, 2020
    Configuration menu
    Copy the full SHA
    63a4b04 View commit details
    Browse the repository at this point in the history

  4. Fix TwoPartyFixedOutcomeApp

    @HeikoFisch
    HeikoFisch committed May 11, 2020
    Configuration menu
    Copy the full SHA
    b3df135 View commit details
    Browse the repository at this point in the history

  5. Add CounterfactualAppInterface to silence warnings 

    ... concerning state mutability restrictions (pure/view) in
`CounterfactualApp`.
    @HeikoFisch
    HeikoFisch committed May 11, 2020
    Configuration menu
    Copy the full SHA
    8ee7fa4 View commit details
    Browse the repository at this point in the history

  6. Use IERC20 where that is sufficient

    @HeikoFisch
    HeikoFisch committed May 11, 2020
    Configuration menu
    Copy the full SHA
    4e90984 View commit details
    Browse the repository at this point in the history

  7. Use OZ code to check whether proxy has been deployed 

    Replace self-written assembly code to check whether the multisig proxy
for a given address has already been deployed with a function provided
by OpenZeppelin.
    @HeikoFisch
    HeikoFisch committed May 11, 2020
    Configuration menu
    Copy the full SHA
    696fc7f View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/staging' into upgrade_to_solidit… 

    …y_v0.6
    @HeikoFisch
    HeikoFisch committed May 11, 2020
    Configuration menu
    Copy the full SHA
    097b15d View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Fix broken watcher tests 

    ERC20 contract needs two constructor arguments (name and symbol of the
token) in OpenZeppelin v3.0.
    @HeikoFisch
    HeikoFisch committed May 12, 2020
    Configuration menu
    Copy the full SHA
    9d3f4c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'staging' into upgrade_to_solidity_v0.6

    @HeikoFisch
    HeikoFisch authored May 12, 2020
    Configuration menu
    Copy the full SHA
    6f1f042 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'upgrade_to_solidity_v0.6' into 1116-init-validation-sol… 

    …idity-v0.6
    @HeikoFisch
    HeikoFisch committed May 12, 2020
    Configuration menu
    Copy the full SHA
    b1bcc30 View commit details
    Browse the repository at this point in the history

  4. Port contract changes from branch 'upgrade_to_solidity_v0.6' to '1116… 

    …-init-validation-solidity-v0.6'
    @HeikoFisch
    HeikoFisch committed May 12, 2020
    Configuration menu
    Copy the full SHA
    f757872 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Port 8acea29 to 'upgrade_to_solidity_v0.6'

    @HeikoFisch
    HeikoFisch committed May 13, 2020
    Configuration menu
    Copy the full SHA
    bc4ae4a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'upgrade_to_solidity_v0.6' into 1116-init-validation-sol… 

    …idity-v0.6
    @HeikoFisch
    HeikoFisch committed May 13, 2020
    Configuration menu
    Copy the full SHA
    610c522 View commit details
    Browse the repository at this point in the history

  3. Port 3c993c2 to '1116-init-validation-solidity-v0.6'

    @HeikoFisch
    HeikoFisch committed May 13, 2020
    Configuration menu
    Copy the full SHA
    da480a3 View commit details
    Browse the repository at this point in the history