This repository has been archived by the owner on May 28, 2021. It is now read-only.
1116 init validation solidity v0.6 #1124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in every Solidity source file.
... to prevent shadowing the state variable with the same name.
OpenZeppelin's ECDSA library now reverts more aggressively, so there were some mismatches in revert messages.
... concerning state mutability restrictions (pure/view) in `CounterfactualApp`.
Replace self-written assembly code to check whether the multisig proxy for a given address has already been deployed with a function provided by OpenZeppelin.
ERC20 contract needs two constructor arguments (name and symbol of the token) in OpenZeppelin v3.0.
…-init-validation-solidity-v0.6'
|
Closing this because we've closed #1117 for now as well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the changes in the contracts and tests that were made for the upgrade to Solidity v0.6 and OpenZeppelin v3.0 to the init validation WIP.