Bug Fixs & Enhancement of Achievement Screen

[neeldoshii]

Description (required)

Related to / Fixes :

• [Bug]: On the personal page, some numerical values are not legible on the smartphone (too small) #5565 [FIXED]
• Totally change how the help pop-up is shown in achievements screen #3441 [FIXED]
• Gamification in general #1558 [Not Completely but Progress Bar gives gamification feel]
• Transform the achievement page's "statistics" section into a "badges" section #5661 [FIXED]
• Part of: Migration of Java Code to Kotlin for Enhanced Code Consistency and Maintainability #5928
• h/to thanks @YujingZHG 5661 statistics to badges #5917

Screenshots

No value(no badge)	have value(show badge)
	l

Commits

e57f666 - This commit just renames the the java file to kotlin so the next commit will have ease in to review using diff for reviewers.
e4977f5 - Migrated to workable kotlin code using Android Studio auto convert and lil manual.
8c1c53f - Removed the ugly nested linear and relative layout to Constraint Layout.
a0a3f23 - Changed the protected to public since unit tests were not able to access it
7e64ca6 - Corrected the String Format to profile page since I changed the level string which got affected on profile page.
5d1ab37 - Badge Implemented & 332f5c5 focused on fix for the previous commit & 7d8a3bf removed the redundant code of xml (do you want me to squash merge this? for ease in rollback )
91c0370 - Changed progress bar color and added the values inside it.

[neeldoshii]

Hi @nicolas-raoul 👋,

1. Just to confirm, are we looking to display progress of (images uploaded, images not reverted, images used) as percentages (e.g., 55%) instead of the current format (e.g., 11/20)? If yes, should the percentage be displayed inside the progress bar or is it fine to show it outside?
   Let me know what works best!
   Context : [Bug]: On the personal page, some numerical values are not legible on the smartphone (too small) #5565 (comment)

2. Is the CI/CD broken?

[nicolas-raoul]

Images not reverted should be shown as %, but the other metrics should be shown as a fraction.

In the issue my screenshot was misleading but I had left a comment above it:

[nicolas-raoul]

I believe CI is not broken, for instance #5960 has the green mark. 🙂

[neeldoshii]

I believe CI is not broken, for instance #5960 has the green mark. 🙂

Make Sense, can you help me with this test case. I am unable to understand what's leading to failure. Btw PR is ready to review.

[nicolas-raoul]

AchievementsFragmentUnitTests > testShowSnackBarWithRetryFalse FAILED
java.lang.reflect.InvocationTargetException at AchievementsFragmentUnitTests.kt:263

I only had a quick glance but the java/kt look equivalent indeed.

Maybe try to run the unit test in debug mode?

[neeldoshii]

Test Case Passed finally :-) Ready to merge @nicolas-raoul 😊

The tests were failing because we didn't handled the on case if progress bar binding is null and we try to call the function.

[nicolas-raoul]

Nor sure if related, but only on this PR several elements that should be bright are show as dark (in bright mode).

[nicolas-raoul]

[nicolas-raoul]

Also:

[nicolas-raoul]