Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform the achievement page's "statistics" section into a "badges" section #5661

Open
nicolas-raoul opened this issue Mar 27, 2024 · 14 comments · May be fixed by #5917
Open

Transform the achievement page's "statistics" section into a "badges" section #5661

nicolas-raoul opened this issue Mar 27, 2024 · 14 comments · May be fixed by #5917

Comments

@nicolas-raoul
Copy link
Member

Similar to GitHub, with for instance a x3 to say that for instance 3 thanks were received:

Screenshot 2024-03-27 at 16 45 44

Tapping each badge would reveal what the badge means.

Badges with zero could be greyed out to generate interest without the negativity of a 0.

Currently it looks like this:
Screenshot 2024-03-27 at 16 49 38

@neeldoshii
Copy link
Contributor

neeldoshii commented Mar 27, 2024

Taking this up while working with #5565

@PetitPotiron
Copy link

I don't see why we should replace the current statistics page (even if it's buggy). It's really good and we don't really need to have the same appearance than GitHub.

@nicolas-raoul
Copy link
Member Author

@PetitPotiron Currently most people see many zeroes, it is discouraging. Badges are more positive, and less boring than lines of statistics.

@PetitPotiron
Copy link

PetitPotiron commented Apr 6, 2024

@nicolas-raoul I understand it can be discouraging.

However, I'm not sure making the upload of quality images funny is a good way either.

It is not a game, and it should stay a hard to achieve process. Otherwise, lots of people would wonder why their images aren't quality ones, and instead of working harder to get better results, they will just fight to get their images labeled.

From my point of view, it will be a loss of time for everyone.

@nicolas-raoul
Copy link
Member Author

@neeldoshii Any progress on your pull request? :-)

@nicolas-raoul
Copy link
Member Author

@neeldoshii I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)

@neeldoshii
Copy link
Contributor

@neeldoshii I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)

Sure 😊

@PetitPotiron
Copy link

Hello @nicolas-raoul
This issue interests me, but I have never done any android development before Anyways, if no one wants to be assigned, I would be glad to be assigned at the beginning of September.
Thanks

@nicolas-raoul
Copy link
Member Author

@PetitPotiron It is yours, thanks! I believe it is a good issue to start Android development. :-)

@YujingZHG
Copy link

Hi! I noticed there hasn’t been any recent progress on this issue. I am a beginner and may I try working on it? and I plan to do like this:
image

@nicolas-raoul
Copy link
Member Author

nicolas-raoul commented Oct 25, 2024

@PetitPotiron Any progress to share on this? :-)

@YujingZHG You can have it, thanks a lot! Your mockup looks great.

@PetitPotiron
Copy link

Thank you.

@YujingZHG YujingZHG linked a pull request Nov 1, 2024 that will close this issue
1 task
@nicolas-raoul
Copy link
Member Author

@YujingZHG did most of the work, anyone willing to continue? Just pull Yujing's pull request branch into your own branch. Thanks all! :-)

@neeldoshii
Copy link
Contributor

I would like to take this issue again by next week.

Approach:

  1. Convert the achievement screen from javato kt since I believe its gonna be much class rewrite as per Bug Fixs & Enhancement of Achievement Screen #5666
  2. I liked the approach of @YujingZHG but I believe its better to move it with Material 3 and kt for a safer transition to compose in future. https://m3.material.io/components/badges/overview

Would be continuing with my old PR #5666 which is fixing 3 issues together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants