Skip to content
This repository has been archived by the owner on Apr 7, 2023. It is now read-only.

Fix missing skipFade check (potential softlock) for screen fade in #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing skipFade check (potential softlock) for screen fade in #209

wants to merge 1 commit into from

Commits on Feb 20, 2022

  1. Fix missing skipFade check for Fade In 

    While attempting to create a custom loading/spawn system using a combination of exports and events, while also wanting to manually control when and how the screen fades in and out (and setting skipFade true), the resource doesn't check for skipFade and forcefully fades the screen in no matter what, and if you override it by forcing a fade out via a while loop, nothing works, everything breaks, the playerSpawned event never fires and the spawning process never completes.

This commit change fixes the above, by adding a skipFade check where it was missing, to prevent a softlock from occurring when manually controlling screen fade, and prevent needing to have the screen fade in just to complete the spawning process.
    @JayMontana36
    JayMontana36 authored Feb 20, 2022
    Configuration menu
    Copy the full SHA
    d0eb578 View commit details
    Browse the repository at this point in the history