This repository has been archived by the owner on Apr 7, 2023. It is now read-only.
Fix missing skipFade check (potential softlock) for screen fade in #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While attempting to create a custom loading/spawn system using a combination of exports and events, while also wanting to manually control when and how the screen fades in and out (and setting skipFade true), the resource doesn't check for skipFade and forcefully fades the screen in no matter what, and if you override it by forcing a fade out via a while loop, nothing works, everything breaks, the playerSpawned event never fires and the spawning process never completes. This commit change fixes the above, by adding a skipFade check where it was missing, to prevent a softlock from occurring when manually controlling screen fade, and prevent needing to have the screen fade in just to complete the spawning process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to create a custom loading/spawn system using a combination of exports and events, while also wanting to manually control when and how the screen fades in and out (and setting skipFade true), the resource doesn't check for skipFade and forcefully fades the screen in no matter what, and should you override that forced fade in (by forcing a fade out at the same time via a while loop), nothing works, everything breaks, the playerSpawned event never fires and the spawning process never completes.
This commit change fixes the above, by adding a skipFade check where it was missing, to prevent a softlock from occurring when manually controlling screen fade, and prevent needing to have the screen fade in just to complete the spawning process.