Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add default webModler url when ingress is disabled #2566

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+9 −1
Open

fix: add default webModler url when ingress is disabled #2566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d90836
fix: add default to webModler url when ingress is disabled
drodriguez-305 Nov 14, 2024
fc90a48
fix: added component support for websockets
drodriguez-305 Nov 19, 2024
91d3e62
fix: formatting
drodriguez-305 Nov 19, 2024
e9e0376
fix: alpha port
drodriguez-305 Nov 19, 2024
e6fb3c1
fix: test
drodriguez-305 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion charts/camunda-platform-8.6/templates/camunda/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,11 @@ Web Modeler templates.
{{- else -}}
{{- printf "%s://%s%s" $proto .context.Values.global.ingress.host (index .context.Values.webModeler "contextPath") -}}
{{- end -}}
{{- end -}}
{{- if eq .component "websockets" }}
{{- printf "http://localhost:8085" -}}
{{- else -}}
{{- printf "http://localhost:8084" -}}
{{- end -}}
{{- end -}}
{{- end -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this should be ported to 8.7-alpha if it's relevant.


Expand Down
4 changes: 4 additions & 0 deletions charts/camunda-platform-alpha/templates/camunda/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,10 @@ Web Modeler templates.
{{- else -}}
{{- printf "%s://%s%s" $proto .context.Values.global.ingress.host (index .context.Values.webModeler "contextPath") -}}
{{- end -}}
{{- if eq .component "websockets" }}
{{- printf "http://localhost:8085" -}}
{{- else -}}
{{- printf "http://localhost:8084" -}}
{{- end -}}
{{- end -}}
{{- end -}}
Expand Down
Loading