fix: add default webModler url when ingress is disabled #2566
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -441,6 +441,8 @@ Web Modeler templates. | |||
| {{- else -}} | |||
| {{- printf "%s://%s%s" $proto .context.Values.global.ingress.host (index .context.Values.webModeler "contextPath") -}} | |||
| {{- end -}} | |||
| {{- else -}} | |||
| {{- printf "http://localhost:8084" -}} | |||
| {{- end -}} | |||
| {{- end -}} | |||
| {{- end -}} | |||
There was a problem hiding this comment.
Also this should be ported to 8.7-alpha if it's relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Console configmap will not read the url if not set in the helpers when there is no ingress. This quickfix will resolve the default static localhost for webModeler.
What's in this PR?
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: