Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add screenshot check on UI #16486

Merged
merged 5 commits into from
Nov 23, 2024
Merged

Add screenshot check on UI #16486

merged 5 commits into from
Nov 23, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Nov 23, 2024 •
edited
Loading

Objective

Solution

  • Get a single screenshot from the UI testbed example
  • Remove older examples from runs in CI as they're covered by the testbed to reduce CI duration

@mockersf mockersf added A-Rendering Drawing game state to the screen A-Build-System Related to build systems or continuous integration labels Nov 23, 2024
@BenjaminBrienen BenjaminBrienen added C-Feature A new feature, making something new possible A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 23, 2024
rparrett
rparrett reviewed Nov 23, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 23, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 23, 2024
Merged via the queue into bevyengine:main with commit 689c21d Nov 23, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@rparrett rparrett rparrett approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @rparrett @BenjaminBrienen @alice-i-cecile