Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth. header to /os/v1/config requests #75

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add auth. header to /os/v1/config requests #75

merged 1 commit into from
Jun 13, 2024

Conversation

ab77
Copy link
Contributor

@ab77 ab77 commented Jun 11, 2024

  • this allows the API to identify devices requesting configuration and apply routing logic (e.g. switch from TCP to UDP OpenVPN configuration)

  • balena-os/meta-balena@c401ebb

change-type: minor

@ab77 ab77 requested review from majorz, alexgg and Page- June 11, 2024 17:27
alexgg
alexgg reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@alexgg alexgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any use case for non-authenticated access - both SSH and VPN are only useful after the device has registered, but it may be worth a wider ping specially to user experience.

The changes look good to me.

@ab77
Add auth. header to /os/v1/config requests
4ea6bf4 
* this allows the API to identify devices requesting configuration and
  apply routing logic (e.g. switch from TCP to UDP OpenVPN configuration)

* balena-os/meta-balena@c401ebb

change-type: minor
Signed-off-by: Anton Belodedenko <2033996+ab77@users.noreply.github.com>
@flowzone-app flowzone-app bot enabled auto-merge June 11, 2024 17:56
@ab77 ab77 mentioned this pull request Jun 11, 2024
Merged
@ab77
Copy link
Contributor Author

ab77 commented Jun 11, 2024 •
edited
Loading

I can't think of any use case for non-authenticated access - both SSH and VPN are only useful after the device has registered, but it may be worth a wider ping specially to user experience.

The changes look good to me.

I'll love to hear the next steps though, how would we install os-config/v1.4.0 (or current master v1.3.0 for that matter) into Yocto pipelines, given they are all currently building/shipping v1.2.11 from 2022..

@ab77 ab77 requested a review from alexgg June 13, 2024 17:19
@alexgg
Copy link
Contributor

alexgg commented Jun 13, 2024

I'll love to hear the next steps though, how would we install os-config/v1.4.0 (or current master v1.3.0 for that matter) into Yocto pipelines

@ab77 we'll need to make os-config build - I think the work was scheduled for this cycle

alexgg
alexgg approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@alexgg alexgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Rust is basic but it's been here for a while so approving.

@flowzone-app flowzone-app bot merged commit 684739e into master Jun 13, 2024
49 checks passed
@flowzone-app flowzone-app bot deleted the ab77/config-auth branch June 13, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgg alexgg alexgg approved these changes

@majorz majorz Awaiting requested review from majorz

@Page- Page- Awaiting requested review from Page-

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ab77 @alexgg