-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth. header to /os/v1/config requests #3443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ab77 why not PR this directly into os-config? We don't maintain patches in meta-balena for sources we own.
I was under the impression we can not build os-config outside of Yocto to make it work with balenaOS cc @Page- @klutchell Happy to make the change directly in the os-config via a PR, and personally, I don't particularly care which way this is done, as long as it ships reasonably soon so we can start identifying devices at the config stage @alexgg |
Just for the record, this PR is likely to be more impactful than |
51e5371
to
c411717
Compare
@alexgg this was discussed in a brainstorm and decided that merging this should be fine to get the ball rolling on device support and then the scarthgap work of @klutchell and @floion will include removing the patch with the updated os-config |
Website deployed to CF Pages, 👀 preview link https://c1acd4a5.balena-os.pages.dev |
Add auth. header to /os/v1/config requests
Allows the API to identify devices requesting configuration and apply routing logic (e.g. switch from TCP to UDP OpenVPN configuration).
In the not-so-distant future we may chose to begin switching devices from the default TCP OpenVPN configuration, to stateless UDP config, to reduce load on the backend and increase reliability of the VPN (Cloudlink) connections. This change adds
Authorization
header to requests{{api}}/os/v1/config
endpoint, with which the API can begin identifying devices and depending on device config vars/model returning the relevant OpenVPN (or other type of configuration)... also balena-os/os-config#75
See: https://balena.fibery.io/Work/Improvement/Add-auth.-header-to-os-v1-config-requests-2176