Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin rpc query and setup btc test infra #41

Closed
1 of 5 tasks
lesterli opened this issue Jul 3, 2024 · 2 comments
Closed
1 of 5 tasks

bitcoin rpc query and setup btc test infra #41

lesterli opened this issue Jul 3, 2024 · 2 comments

Comments

@lesterli
Copy link
Contributor

lesterli commented Jul 3, 2024 •
edited by bap2pecs
Loading

Summary

#39 (review)

Gai: Just wanted to understand the context. Why not use btc client like https://github.com/babylonchain/staking-indexer/blob/51d98f1dbafda2fbbe550599c83331b549d26a6c/btcclient/client.go#L23?

babylonchain/finality-provider#483 (comment)

Runchao: besides mocking BTC node, one can also leverage the https://github.com/btcsuite/btcd/tree/master/integration/rpctest package for testing things against an almost real BTC node. But this can be done in the future.

Tasks

  • refactor bitcoin rpc query using this
  • rewrite btc tests to not depend on ankr RPC
  • decide whether we should leverage the rpctest or bitcoind package for testing things against an almost real BTC node. finalise the design with the Babylon team
  • rewrite the tests using the btc test infra
  • add more btcclient tests for some edge cases
@lesterli lesterli mentioned this issue Jul 3, 2024
Merged
@parketh
Copy link
Contributor

parketh commented Jul 4, 2024 •
edited by bap2pecs
Loading

now updated Bitcoin rpc to use btcclient with this commit

This was referenced Jul 4, 2024
Closed
Merged
@bap2pecs bap2pecs closed this as completed Jul 8, 2024
@bap2pecs bap2pecs changed the title refactor bitcoin rpc query and setup a bitcoind node for testing Refactor: bitcoin rpc query and setup btc test infra Jul 9, 2024
@bap2pecs bap2pecs reopened this Jul 9, 2024
@bap2pecs bap2pecs changed the title Refactor: bitcoin rpc query and setup btc test infra bitcoin rpc query and setup btc test infra Jul 16, 2024
@bap2pecs
Copy link
Contributor

Kamino closed and cloned this issue to babylonlabs-io/babylon-finality-gadget

@bap2pecs bap2pecs mentioned this issue Jul 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lesterli @parketh @bap2pecs