Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoin rpc query and setup btc test infra #3

Open
bap2pecs opened this issue Jul 31, 2024 · 1 comment
Open

bitcoin rpc query and setup btc test infra #3

bap2pecs opened this issue Jul 31, 2024 · 1 comment

Comments

@bap2pecs
Copy link
Collaborator

bap2pecs commented Jul 31, 2024

@lesterli cloned issue babylonchain/babylon-finality-gadget#41 on 2024-07-03:

Summary

babylonchain/babylon-finality-gadget#39 (review)

Gai: Just wanted to understand the context. Why not use btc client like https://github.com/babylonchain/staking-indexer/blob/51d98f1dbafda2fbbe550599c83331b549d26a6c/btcclient/client.go#L23?

babylonchain/finality-provider#483 (comment)

Runchao: besides mocking BTC node, one can also leverage the https://github.com/btcsuite/btcd/tree/master/integration/rpctest package for testing things against an almost real BTC node. But this can be done in the future.

Tasks

  • refactor bitcoin rpc query using this

  • rewrite btc tests to not depend on ankr RPC

  • decide whether we should leverage the rpctest or bitcoind package for testing things against an almost real BTC node. finalise the design with the Babylon team

  • rewrite the tests using the btc test infra

  • add more btcclient tests for some edge cases

  • remove mock btc client and get rid of mock btc client in FP e2e test

@bap2pecs
Copy link
Collaborator Author

@parketh commented on 2024-07-04:

now updated Bitcoin rpc to use btcclient with this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant