Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op e2e: refactor bitcoin rpc url to use BTCClient #468

Closed
parketh opened this issue Jul 4, 2024 · 1 comment · Fixed by #471
Closed

op e2e: refactor bitcoin rpc url to use BTCClient #468

parketh opened this issue Jul 4, 2024 · 1 comment · Fixed by #471

Comments

@parketh
Copy link

parketh commented Jul 4, 2024 •
edited
Loading

At the moment when running op e2e tests, we pass in a bitcoin mainnet rpc url to query the block finalization status.

We should refactor this to:

  1. use the BTCClient interface as per this
  2. (optionally) spin up a local bitcoind note to bypass rpc rate limits

This issue is related to babylonchain/babylon-finality-gadget#41
@parketh parketh changed the title op e2e: refactor bitcoin RPC url to btc client op e2e: refactor bitcoin rpc url to use BTCClient Jul 4, 2024
@parketh parketh mentioned this issue Jul 4, 2024
Merged
@gitferry
Copy link
Contributor

gitferry commented Jul 5, 2024

Here's a reference of how our indexer does the e2e with bitcoind https://github.com/babylonchain/staking-indexer/blob/d085cbfa868f7b45be9b83e72c18911087fd5773/itest/bitcoind_node_setup.go#L38

@bap2pecs bap2pecs closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: refactor op e2e tests to use BTCClient babylonchain/finality-provider
3 participants
@gitferry @parketh @bap2pecs