Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new parameters and tests to one-off task feature #593

Merged
merged 63 commits into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from 62 commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
60ec296
je ne sais pas
shesaave Jun 27, 2024
61622e0
Create testing.json
shesaave Jun 28, 2024
7b76e34
Create aws.yml
shesaave Jun 28, 2024
1093f1e
new files that i created for the ecs cluster,service and task
shesaave Jun 28, 2024
ad83536
Update aws.yml
shesaave Jun 28, 2024
762d80b
Update aws.yml
shesaave Jun 28, 2024
11f792f
Update aws.yml
shesaave Jun 28, 2024
e2389a4
Update aws.yml
shesaave Jun 28, 2024
2bd57b3
Delete testing.json
shesaave Jun 28, 2024
97604c3
Delete .github/workflows/aws.yml
shesaave Jun 28, 2024
4669e8a
Merge branch 'aws-actions:master' into master
shesaave Jul 2, 2024
d86ee7d
implemented unit tests
shesaave Jul 9, 2024
9bf2bd1
Merge branch 'aws-actions:master' into master
shesaave Jul 9, 2024
ce69720
"Added support for creating individual clusters for tasks and service…
shesaave Jul 11, 2024
3ee2cc6
"Refactor ECS deployment code: updated input handling, removed create…
shesaave Jul 12, 2024
8981030
"Updated action.yml, index.js, and index.test.js files with changes t…
shesaave Jul 14, 2024
d0dda83
updated action.yml by removing comments
shesaave Jul 15, 2024
2c63b0d
added inputs to action.yml for capacity provider
shesaave Jul 15, 2024
95146ff
added solid inputs in the capacity provider
shesaave Jul 15, 2024
9b9fbb8
fixed order of capacity provider order inputs in action.yml file
shesaave Jul 15, 2024
ad04d2c
changed capacity provider description to double quotes and shortend it
shesaave Jul 15, 2024
18bcf2a
removed spacing from list in capacity provider in action.yml file
shesaave Jul 15, 2024
9af5ecd
fixing the spacing and list of capacity provider in action.yml file
shesaave Jul 15, 2024
d090db9
fixing spacing on capacity provider of action.yml file
shesaave Jul 15, 2024
03d2b63
deleted list line in capacity provider of action.yml file
shesaave Jul 15, 2024
9cb186a
Delete .idea/aws.xml
shesaave Jul 15, 2024
8c9b320
Delete .idea/inspectionProfiles/Project_Default.xml
shesaave Jul 15, 2024
a1484cf
Delete .idea/misc.xml
shesaave Jul 15, 2024
3bdad8d
Delete .idea/vcs.xml
shesaave Jul 15, 2024
3dda01c
Delete .idea/workspace.xml
shesaave Jul 15, 2024
125df13
"Removed capacityProviderStrategy from function parameters and implem…
shesaave Jul 17, 2024
2c355ae
Merge remote-tracking branch 'refs/remotes/origin/master'
shesaave Jul 17, 2024
617c1b0
Updated the code with no capacity provider
shesaave Jul 17, 2024
9aafc1b
removed capacity provider option from action.yml
shesaave Jul 17, 2024
a4c9569
updated action.yml file with commentary on new and original inputs
shesaave Jul 17, 2024
ce8ff4e
Merge branch 'master' into master
shesaave Jul 18, 2024
e87445e
"Added support for running ECS tasks outside of a service, updated EC…
shesaave Jul 18, 2024
0765d2c
Merge remote-tracking branch 'refs/remotes/origin/master'
shesaave Jul 18, 2024
c869fa9
spacing
shesaave Jul 18, 2024
3859ae5
updating dist file after modifying index.js file
shesaave Jul 18, 2024
49322b3
Added tests to check when a task fails whne it tries to stop and when…
shesaave Jul 19, 2024
4277959
Testing default options in run task unit test
shesaave Jul 19, 2024
ab80cfa
added assign public IP input and settings
shesaave Jul 26, 2024
231f294
fixing action.yml file line 57 error
shesaave Jul 26, 2024
aab45d6
fixing additional comments from reviewers
shesaave Jul 26, 2024
794d0cb
updating aws sdk version
shesaave Jul 26, 2024
2e296b3
updated running task link to ECS
shesaave Jul 26, 2024
aeebecd
updated running task link to ECS and read me file
shesaave Jul 26, 2024
8af8df8
updated run task description in action.yml for clearer usage of feature
shesaave Jul 29, 2024
5c85165
Merge branch 'aws-actions:master' into master
shesaave Jul 29, 2024
daa82a9
updated run task description in action.yml
shesaave Jul 29, 2024
b2b09e1
Merge branch 'master' into master
shesaave Jul 29, 2024
5944873
changes
shesaave Jul 29, 2024
0bebccc
Merge branch 'master' of https://github.com/shesaave/amazon-ecs-deplo…
shesaave Jul 29, 2024
3978fee
delete sdk version 2
shesaave Jul 29, 2024
c279797
final changes from comments
shesaave Jul 29, 2024
4cc9e49
cleaning up code and organzie
shesaave Jul 30, 2024
8d8cb7d
rebasing upon latest changes
shesaave Jul 30, 2024
a69bca0
new changes, removing spaces and correcting indentation
shesaave Jul 30, 2024
414e5e8
fixing indentation
shesaave Jul 30, 2024
4a82be7
fixing indentation part 2
shesaave Jul 30, 2024
a7d481b
changes to testing errors
shesaave Jul 30, 2024
099f783
changes to new test
shesaave Jul 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Registers an Amazon ECS task definition and deploys it to an ECS service.
```

See [action.yml](action.yml) for the full documentation for this action's inputs and outputs.
In most cases when running a one-off task, subnet ID's, subnet groups, and assign public IP will be required.

### Task definition file

Expand Down
5 changes: 4 additions & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ inputs:
description: 'Whether to force a new deployment of the service. Valid value is "true". Will default to not force a new deployment.'
required: false
run-task:
description: 'Whether to run the task outside of an ECS service. Task will run before the service is updated if both are provided. Will default to not run.'
description: 'A boolean indicating whether to run a stand-alone task in a ECS cluster. Task will run before the service is updated if both are provided. Default value is false .'
required: false
run-task-container-overrides:
description: 'A JSON array of container override objects which should applied when running a task outside of a service. Warning: Do not expose this field to untrusted inputs. More details: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_ContainerOverride.html'
Expand All @@ -52,6 +52,9 @@ inputs:
run-task-subnets:
description: 'A comma-separated list of subnet IDs to assign to a task when run outside of a service. Will default to none.'
required: false
run-task-assign-public-IP:
description: "Whether the task's elastic network interface receives a public IP address. The default value is DISABLED."
required: false
run-task-launch-type:
description: "ECS launch type for tasks run outside of a service. Valid values are 'FARGATE' or 'EC2'. Will default to 'FARGATE'."
required: false
Expand Down
Loading
Loading