Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new parameters and tests to one-off task feature #593

Merged
merged 63 commits into from
Jul 30, 2024

Conversation

shesaave
Copy link
Contributor

@shesaave shesaave commented Jul 30, 2024

Issue #, if available: #54 and #304 and #273

Description of changes: Added additional tests and parameter to #304 , this feature is known as a one-off task.

Description of Existing Tests

The ability to have a one off task run with default inputs

  • You can run your task with any inputs the default ones are always there for secure compilation.

The ability to have a one off task run with desired settings

  • You can select the desired settings for your one-off task and remove any if needed

Checking when a task stops if it stops/fails properly

  • you are able to use one of these options for your one-off task: wait-for-task-stopped
  • if this input is selected your task should run and call the wait-for-task-stopped conditionals and API runTask
  • Otherwise, a separate tests allows an error can appear indicating that the input didn't properly run

New implemented parameters and tests

Assign public IP feature for secure deployment
Additional tests for wait-for-task-stopped
The ability to have a one off task run and also a service

  • You can select the desired settings for your one-off task and remove any if needed
  • You can run your service with the desired setting and inputs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…s, updated runTask and updateEcsService functions to use new cluster names, and modified tests to accommodate new cluster creation"
… cluster command, added capacity provider strategy, and modified tests"
…o capacity provider strategy, task definition, and ECS service updates."
Copy link
Contributor

@amazreech amazreech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added to Block auto-merging.

Copy link
Contributor

@amazreech amazreech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amazreech amazreech merged commit 67393b6 into aws-actions:master Jul 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants