Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation about ONNX models #345

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Mar 30, 2023

Description

This PR adds a section about how to download ONNX models.

Fixes autowarefoundation/autoware.universe#3137

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@stale
Copy link

stale bot commented May 29, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 29, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jun 9, 2023
@esteve esteve marked this pull request as ready for review June 9, 2023 07:34
@esteve esteve force-pushed the documentation-onnx branch 2 times, most recently from 1fa5963 to b185f20 Compare July 12, 2023 10:27
@esteve
Copy link
Contributor Author

esteve commented Jul 12, 2023

@xmfcx @mitsudome-r this PR is now ready for review

@esteve
Copy link
Contributor Author

esteve commented Sep 15, 2023

Needs same updates as autowarefoundation/autoware#3375 (comment)

@esteve esteve marked this pull request as draft September 15, 2023 07:50
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve marked this pull request as ready for review September 15, 2023 09:07
@esteve
Copy link
Contributor Author

esteve commented Sep 15, 2023

@lexavtanke I've updated the PR so that per-package directories are created in the correct path, can you have another look? Thanks.

@lexavtanke lexavtanke self-requested a review September 19, 2023 14:00
Copy link
Contributor

@lexavtanke lexavtanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esteve Thank you. It is clear now how to get models without ansible.

@esteve
Copy link
Contributor Author

esteve commented Sep 19, 2023

@lexavtanke thanks for the review

@esteve esteve merged commit 5a054d1 into autowarefoundation:main Sep 19, 2023
8 checks passed
@esteve esteve deleted the documentation-onnx branch September 19, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move downloading artifacts outside CMake
2 participants