Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: types refactoring #1063

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
+6 −12
Open

refactor: types refactoring #1063

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a0522f7
REF: refactoring Extensions.tsx file
DhairyaMajmudar Oct 2, 2024
0431f58
fix: types refactoring
DhairyaMajmudar Oct 2, 2024
4945997
fix: types refactoring
DhairyaMajmudar Oct 2, 2024
1b889b4
Merge branch 'master' into refactor
AceTheCreator Oct 7, 2024
5d6eb34
Merge branch 'master' into refactor
AceTheCreator Oct 7, 2024
e67ab85
Merge branch 'master' into refactor
DhairyaMajmudar Oct 8, 2024
1552664
fixing build failures
DhairyaMajmudar Oct 8, 2024
2402425
Merge branch 'master' into refactor
AceTheCreator Oct 14, 2024
706e9c5
Merge branch 'master' into refactor
DhairyaMajmudar Oct 14, 2024
58c2457
Merge branch 'master' into refactor
AceTheCreator Nov 4, 2024
642d403
Merge branch 'master' into refactor
AceTheCreator Nov 4, 2024
663af15
Merge branch 'master' into refactor
AceTheCreator Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions library/src/components/Extensions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
/* eslint-disable @typescript-eslint/no-unsafe-return */
/* eslint-disable @typescript-eslint/no-unsafe-assignment */

import React from 'react';

import { Schema } from './Schema';
import type { SchemaInterface } from '@asyncapi/parser';

import { SchemaHelpers } from '../helpers';

interface Props {
name?: string;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
item: any;
item: SchemaInterface;
}

export const Extensions: React.FunctionComponent<Props> = ({
Expand All @@ -22,7 +19,7 @@ export const Extensions: React.FunctionComponent<Props> = ({
return null;
}

const schema = SchemaHelpers.jsonToSchema(extensions);
const schema: SchemaInterface = SchemaHelpers.jsonToSchema(extensions);

return (
schema && (
Expand Down
4 changes: 1 addition & 3 deletions library/src/components/Schema.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,9 +512,7 @@ const AdditionalItems: React.FunctionComponent<AdditionalItemsProps> = ({
if (!Array.isArray(schema.items())) {
return null;
}

// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
const additionalItems = schema.additionalItems() as any;
const additionalItems = schema.additionalItems();
if (additionalItems === true || additionalItems === undefined) {
return (
<p className="mt-2 text-xs text-gray-700">
Expand Down
3 changes: 1 addition & 2 deletions library/src/contexts/useSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ import React, { useContext } from 'react';
import { AsyncAPIDocumentInterface } from '@asyncapi/parser';

export const SpecificationContext =
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-explicit-any
React.createContext<AsyncAPIDocumentInterface>(null as any);
React.createContext<AsyncAPIDocumentInterface>(null as never);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your changes here is unnecessarily strict and semantically incorrect in this scenario. I'd suggest we use the existing type :)


export function useSpec() {
return useContext(SpecificationContext);
Expand Down
2 changes: 1 addition & 1 deletion library/src/helpers/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export class SchemaHelpers {
}

// eslint-disable-next-line @typescript-eslint/no-explicit-any
static jsonToSchema(value: any): any {
static jsonToSchema(value: any): SchemaInterface {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const json = this.jsonFieldToSchema(value);
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
Expand Down
8 changes: 3 additions & 5 deletions web-component/src/AsyncApiWebComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,10 @@ function retrieveSchemaProp(
let schemaFetchOptions = props.schemaFetchOptions;

if (!schemaUrl || schemaUrl === 'undefined') {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
schemaUrl = undefined as any;
schemaUrl = undefined;
}
if (!schemaFetchOptions) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
schemaFetchOptions = undefined as any;
schemaFetchOptions = undefined;
}

let schema = props.schema || {};
Expand All @@ -50,7 +48,7 @@ function retrieveSchemaProp(
export interface AsyncApiWebComponentProps extends AsyncApiProps {
cssImportPath?: string;
schemaFetchOptions?: RequestInit;
schemaUrl: string;
schemaUrl?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DhairyaMajmudar the schemaUrl is not an optional value

}

export class AsyncApiWebComponent extends React.Component<AsyncApiWebComponentProps> {
Expand Down
Loading