refactor: types refactoring #1063
Conversation
DhairyaMajmudar
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
DhairyaMajmudar
changed the title
I've fixed them 👍🏻 |
|
| @@ -50,7 +48,7 @@ function retrieveSchemaProp( | |||
| export interface AsyncApiWebComponentProps extends AsyncApiProps { | |||
| cssImportPath?: string; | |||
| schemaFetchOptions?: RequestInit; | |||
| schemaUrl: string; | |||
| schemaUrl?: string; | |||
There was a problem hiding this comment.
@DhairyaMajmudar the schemaUrl is not an optional value
| @@ -2,8 +2,7 @@ import React, { useContext } from 'react'; | |||
| import { AsyncAPIDocumentInterface } from '@asyncapi/parser'; | |||
|
|
|||
| export const SpecificationContext = | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-explicit-any | |||
| React.createContext<AsyncAPIDocumentInterface>(null as any); | |||
| React.createContext<AsyncAPIDocumentInterface>(null as never); | |||
There was a problem hiding this comment.
I think your changes here is unnecessarily strict and semantically incorrect in this scenario. I'd suggest we use the existing type :)
| @@ -1,6 +1,5 @@ | |||
| /* eslint-disable @typescript-eslint/no-unsafe-return */ | |||
| /* eslint-disable @typescript-eslint/no-unsafe-assignment */ | |||
|
|
|||
There was a problem hiding this comment.
I think this line should be removed
Description
Changes proposed in this pull request:
-> Refactoring files by removing any keywords and typescript warnings disabling comments
cc: @AceTheCreator
Related issue(s)
N/A